Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e8e33ba authored by Aravind Venkateswaran's avatar Aravind Venkateswaran Committed by Gerrit - the friendly Code Review server
Browse files

msm: mdss: modify DSI phy init sequence for split-DSI config 



For split-DSI hardware configuration, both the DSI controller clocks are
sourced from a single PLL (clock-master). In such cases, it is important
to initialize both DSI0 PHY and DSI1 PHY prior to enabling the PLL.
This is due to the fact that for certain HW versions, PLL programming
for the clock-master may require configure some PLL registers on the
clock-slave. If the PHY init sequence for the clock-slave is called
after PLL is programmed, it could reset those PLL registers leading to
unexpected behavior. Fix this by ensuring that PHY init sequence is done
for both controllers at the same time for split display usecases.

CRs-Fixed: 1000724
Change-Id: I09fb8097d31cd0390cea5c32bb7aabceeff2c37e
Signed-off-by: default avatarAravind Venkateswaran <aravindh@codeaurora.org>
Signed-off-by: default avatarAshish Garg <ashigarg@codeaurora.org>
parent b3dd642b

drivers/video/msm/mdss/msm_mdss_io_8974.c

+58 −2
Original line number Diff line number Diff line
@@ -443,7 +443,7 @@ int mdss_dsi_phy_pll_reset_status(struct mdss_dsi_ctrl_pdata *ctrl) 
	return rc;

}



void mdss_dsi_phy_sw_reset(struct mdss_dsi_ctrl_pdata *ctrl)

static void mdss_dsi_phy_sw_reset_sub(struct mdss_dsi_ctrl_pdata *ctrl)

{

	struct mdss_dsi_ctrl_pdata *sctrl = NULL;

	struct dsi_shared_data *sdata;
@@ -500,7 +500,39 @@ void mdss_dsi_phy_sw_reset(struct mdss_dsi_ctrl_pdata *ctrl) 


	}

	mutex_unlock(&sdata->phy_reg_lock);

}



void mdss_dsi_phy_sw_reset(struct mdss_dsi_ctrl_pdata *ctrl)

{

	struct mdss_dsi_ctrl_pdata *sctrl = NULL;

	struct dsi_shared_data *sdata;



	if (ctrl == NULL) {

		pr_err("%s: Invalid input data\n", __func__);

		return;

	}



	sdata = ctrl->shared_data;



	/*

	 * When operating in split display mode, make sure that the PHY reset

	 * is only done from the clock master. This will ensure that the PLL is

	 * off when PHY reset is called.

	 */

	if (mdss_dsi_is_ctrl_clk_slave(ctrl))

		return;



	mdss_dsi_phy_sw_reset_sub(ctrl);



	if (mdss_dsi_is_ctrl_clk_master(ctrl)) {

		sctrl = mdss_dsi_get_ctrl_clk_slave();

		if (sctrl)

			mdss_dsi_phy_sw_reset_sub(sctrl);

		else

			pr_warn("%s: unable to get slave ctrl\n", __func__);

	}



	/* All other quirks go here */

	if ((sdata->hw_rev == MDSS_DSI_HW_REV_103) &&

		!mdss_dsi_is_hw_config_dual(sdata) &&

		mdss_dsi_is_right_ctrl(ctrl)) {
@@ -1202,12 +1234,36 @@ void mdss_dsi_phy_disable(struct mdss_dsi_ctrl_pdata *ctrl) 
	wmb();

}



void mdss_dsi_phy_init(struct mdss_dsi_ctrl_pdata *ctrl)

static void mdss_dsi_phy_init_sub(struct mdss_dsi_ctrl_pdata *ctrl)

{

	mdss_dsi_phy_regulator_ctrl(ctrl, true);

	mdss_dsi_phy_ctrl(ctrl, true);

}



void mdss_dsi_phy_init(struct mdss_dsi_ctrl_pdata *ctrl)

{

	struct mdss_dsi_ctrl_pdata *sctrl = NULL;



	/*

	 * When operating in split display mode, make sure that both the PHY

	 * blocks are initialized together prior to the PLL being enabled. This

	 * is achieved by calling the phy_init function for the clk_slave from

	 * the clock_master.

	 */

	if (mdss_dsi_is_ctrl_clk_slave(ctrl))

		return;



	mdss_dsi_phy_init_sub(ctrl);



	if (mdss_dsi_is_ctrl_clk_master(ctrl)) {

		sctrl = mdss_dsi_get_ctrl_clk_slave();

		if (sctrl)

			mdss_dsi_phy_init_sub(sctrl);

		else

			pr_warn("%s: unable to get slave ctrl\n", __func__);

	}

}



void mdss_dsi_core_clk_deinit(struct device *dev, struct dsi_shared_data *sdata)

{

	if (sdata->mmss_misc_ahb_clk)