Commit 4ab867d2 authored Nov 16, 2010 by Axel Lin Committed by Mark Brown Nov 16, 2010

ASoC: Fix incorrect kfree in aic3x_probe error path



We allocated memory for aic3x in aic3x_i2c_probe,
and will free the memory in either aic3x_i2c_probe error path or
aic3x_i2c_remove.

Thus we should not call kfree(aic3x) in aic3x_probe, otherwise
we have double free of aic3x.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 50d0ac2e

sound/soc/codecs/tlv320aic3x.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1419,7 +1419,6 @@ err_get:
		if (aic3x->gpio_reset >= 0)
		gpio_free(aic3x->gpio_reset);
		err_gpio:
		kfree(aic3x);
		return ret;
		}