Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48938181 authored by Eric Dumazet's avatar Eric Dumazet Committed by Dennis Cagle
Browse files

ipv4: keep skb->dst around in presence of IP options



Andrey Konovalov got crashes in __ip_options_echo() when a NULL skb->dst
is accessed.

ipv4_pktinfo_prepare() should not drop the dst if (evil) IP options
are present.

We could refine the test to the presence of ts_needtime or srr,
but IP options are not often used, so let's be conservative.

Thanks to syzkaller team for finding this bug.

Change-Id: I5e1dd678cfb3f968225995b0ff086ac42854ee8d
Fixes: d826eb14 ("ipv4: PKTINFO doesnt need dst reference")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git


Git-commit: 34b2cef20f19c87999fff3da4071e66937db9644
Signed-off-by: default avatarDennis Cagle <dcagle@codeaurora.org>
parent a21201d2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment