Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ed2bb49 authored by Rainer Weikusat's avatar Rainer Weikusat Committed by Dennis Cagle
Browse files

af_unix: Guard against other == sk in unix_dgram_sendmsg



The unix_dgram_sendmsg routine use the following test

if (unlikely(unix_peer(other) != sk && unix_recvq_full(other))) {

to determine if sk and other are in an n:1 association (either
established via connect or by using sendto to send messages to an
unrelated socket identified by address). This isn't correct as the
specified address could have been bound to the sending socket itself or
because this socket could have been connected to itself by the time of
the unix_peer_get but disconnected before the unix_state_lock(other). In
both cases, the if-block would be entered despite other == sk which
might either block the sender unintentionally or lead to trying to unlock
the same spin lock twice for a non-blocking send. Add a other != sk
check to guard against this.

Change-Id: I088f5d2bc9392cb3510bd1a65c96d45ad7b89cd6
Fixes: 7d267278a9ec ("unix: avoid use-after-free in ep_remove_wait_queue")
Reported-By: default avatarPhilipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: default avatarRainer Weikusat <rweikusat@mobileactivedefense.com>
Tested-by: default avatarPhilipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git


Git-commit: a5527dda344fff0514b7989ef7a755729769daa1
Signed-off-by: default avatarDennis Cagle <d-cagle@codeaurora.org>
parent ef3068bf
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment