Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14a9579d authored by Alex Deucher's avatar Alex Deucher Committed by Christian König
Browse files

drm/radeon: use variable UVD clocks 



Now that Christian fixed the performance problems with
the feedback buffer in mesa, we can enable variable UVD
clocks.  There are multiple UVD power states associated
with different types and numbers of streams.  This uses
the appropriate state based on that information rather
than always using the fastest UVD clocks which saves some
power.  One possible downside is that this may adversely
affect decode benchmarks since these power states target
specific playback requirements rather than maximum
performance.  If that becomes an issue, we can add a
sysfs attribute to force the max UVD state.

Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
parent 37615527

drivers/gpu/drm/radeon/radeon_pm.c

+0 −3
Original line number Diff line number Diff line
@@ -943,8 +943,6 @@ void radeon_dpm_enable_uvd(struct radeon_device *rdev, bool enable) 
		if (enable) {

			mutex_lock(&rdev->pm.mutex);

			rdev->pm.dpm.uvd_active = true;

			/* disable this for now */

#if 0

			if ((rdev->pm.dpm.sd == 1) && (rdev->pm.dpm.hd == 0))

				dpm_state = POWER_STATE_TYPE_INTERNAL_UVD_SD;

			else if ((rdev->pm.dpm.sd == 2) && (rdev->pm.dpm.hd == 0))
@@ -954,7 +952,6 @@ void radeon_dpm_enable_uvd(struct radeon_device *rdev, bool enable) 
			else if ((rdev->pm.dpm.sd == 0) && (rdev->pm.dpm.hd == 2))

				dpm_state = POWER_STATE_TYPE_INTERNAL_UVD_HD2;

			else

#endif

				dpm_state = POWER_STATE_TYPE_INTERNAL_UVD;

			rdev->pm.dpm.state = dpm_state;

			mutex_unlock(&rdev->pm.mutex);

drivers/gpu/drm/radeon/radeon_uvd.c

+1 −2
Original line number Diff line number Diff line
@@ -805,8 +805,7 @@ void radeon_uvd_note_usage(struct radeon_device *rdev) 
		    (rdev->pm.dpm.hd != hd)) {

			rdev->pm.dpm.sd = sd;

			rdev->pm.dpm.hd = hd;

			/* disable this for now */

			/*streams_changed = true;*/

			streams_changed = true;

		}

	}