Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0eb91c32 authored by Hamad Kadmany's avatar Hamad Kadmany Committed by Maya Erez
Browse files

wil6210: fix kernel OOPS when stopping interface during Rx traffic 



When network interface is stopping, some resources may
be already released by the network stack, and Rx frames
cause kernel OOPS (observed one is in netfilter code)

Proper solution is to drop packets pending in reorder buffer.

Change-Id: Id043d466135f20fe980814380e6f01e2554c22e3
Signed-off-by: default avatarHamad Kadmany <qca_hkadmany@qca.qualcomm.com>
Signed-off-by: default avatarVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: default avatarMaya Erez <qca_merez@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
Git-commit: dea16eddb4753129dbcd8dc8d1a58ff0cc4ea38c
Git-repo: https://github.com/kvalo/ath.git


Signed-off-by: default avatarMaya Erez <merez@codeaurora.org>
parent a9c911e2

drivers/net/wireless/ath/wil6210/rx_reorder.c

+11 −1
Original line number Diff line number Diff line
@@ -261,9 +261,19 @@ struct wil_tid_ampdu_rx *wil_tid_ampdu_rx_alloc(struct wil6210_priv *wil, 
void wil_tid_ampdu_rx_free(struct wil6210_priv *wil,

			   struct wil_tid_ampdu_rx *r)

{

	int i;



	if (!r)

		return;

	wil_release_reorder_frames(wil, r, r->head_seq_num + r->buf_size);



	/* Do not pass remaining frames to the network stack - it may be

	 * not expecting to get any more Rx. Rx from here may lead to

	 * kernel OOPS since some per-socket accounting info was already

	 * released.

	 */

	for (i = 0; i < r->buf_size; i++)

		kfree_skb(r->reorder_buf[i]);



	kfree(r->reorder_buf);

	kfree(r->reorder_time);

	kfree(r);