Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 040f0b15 authored by Mayank Rana's avatar Mayank Rana
Browse files

usb: dwc3: Replace WARN_ON() by WARN_ON_ONCE() and logging with buffer 



In some of cases when ep0 operations are fails, WARN_ON is called from
interrupt context. This may lead to watchdog bark if repeated WARN_ON
condition occurs. Hence replace usage of WARN_ON() by WARN_ON_ONCE() and
logging errror as part of debug buffer.

CRs-Fixed: 907077
Change-Id: I40de055b1e8d610c43c7fff32cd904c43b9bec00
Signed-off-by: default avatarMayank Rana <mrana@codeaurora.org>
parent e7c95927

drivers/usb/dwc3/ep0.c

+9 −5
Original line number Diff line number Diff line
@@ -309,7 +309,9 @@ void dwc3_ep0_out_start(struct dwc3 *dwc) 


	ret = dwc3_ep0_start_trans(dwc, 0, dwc->ctrl_req_addr, 8,

			DWC3_TRBCTL_CONTROL_SETUP);

	WARN_ON(ret < 0);



	if (WARN_ON_ONCE(ret < 0))

		dbg_event(dwc->eps[0]->number, "EOUTSTART", ret);

}



static struct dwc3_ep *dwc3_wIndex_to_dep(struct dwc3 *dwc, __le16 wIndex_le)
@@ -665,7 +667,8 @@ static void dwc3_ep0_set_sel_cmpl(struct usb_ep *ep, struct usb_request *req) 
	/* now that we have the time, issue DGCMD Set Sel */

	ret = dwc3_send_gadget_generic_command(dwc,

			DWC3_DGCMD_SET_PERIODIC_PAR, param);

	WARN_ON(ret < 0);

	if (WARN_ON_ONCE(ret < 0))

		dbg_event(dep->number, "ESET_SELCMPL", ret);

}



static int dwc3_ep0_set_sel(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)
@@ -888,7 +891,8 @@ static void dwc3_ep0_complete_data(struct dwc3 *dwc, 
			ret = dwc3_ep0_start_trans(dwc, epnum,

					dwc->ctrl_req_addr, 0,

					DWC3_TRBCTL_CONTROL_DATA);

			WARN_ON(ret < 0);

			if (WARN_ON_ONCE(ret < 0))

				dbg_event(epnum, "ECTRL_DATA", ret);

		}

	}

}
@@ -1040,8 +1044,8 @@ static void __dwc3_ep0_do_control_status(struct dwc3 *dwc, struct dwc3_ep *dep) 
	}



	ret = dwc3_ep0_start_control_status(dep);

	dbg_print(dep->number, "QUEUE", ret, "STATUS");

	WARN_ON(ret);

	if (WARN_ON_ONCE(ret))

		dbg_event(dep->number, "ECTRLSTATUS", ret);

}



static void dwc3_ep0_do_control_status(struct dwc3 *dwc,