Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5645ec7 authored by Maxim Petrov's avatar Maxim Petrov Committed by Greg Kroah-Hartman
Browse files

stmmac: fix pointer check after utilization in stmmac_interrupt



[ Upstream commit f42234ffd531ca6b13d9da02faa60b72eccf8334 ]

The paranoidal pointer check in IRQ handler looks very strange - it
really protects us only against bogus drivers which request IRQ line
with null pointer dev_id. However, the code fragment is incorrect
because the dev pointer is used before the actual check which leads
to undefined behavior. Remove the check to avoid confusing people
with incorrect code.

Signed-off-by: default avatarMaxim Petrov <mmrmaximuzz@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7b9e34e8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment