Commit ddf98e6d authored Dec 02, 2011 by Thomas Meyer Committed by David S. Miller Dec 04, 2011

ll_temac: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a1de2219

drivers/net/ethernet/xilinx/ll_temac_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev)
		struct sk_buff *skb;
		int i;

		lp->rx_skb = kzalloc(sizeof(lp->rx_skb) RX_BD_NUM, GFP_KERNEL);
		lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL);
		if (!lp->rx_skb) {
		dev_err(&ndev->dev,
		"can't allocate memory for DMA RX buffer\n");