Commit a1de2219 authored Nov 29, 2011 by Thomas Meyer Committed by David S. Miller Dec 04, 2011

enic: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 01e23742

drivers/net/ethernet/cisco/enic/enic_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2379,7 +2379,7 @@ static int __devinit enic_probe(struct pci_dev *pdev,

		#endif
		/* Allocate structure for port profiles */
		enic->pp = kzalloc(num_pps * sizeof(*enic->pp), GFP_KERNEL);
		enic->pp = kcalloc(num_pps, sizeof(*enic->pp), GFP_KERNEL);
		if (!enic->pp) {
		pr_err("port profile alloc failed, aborting\n");
		err = -ENOMEM;