Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c560451c authored Jan 09, 2013 by Alexander Duyck Committed by Jeff Kirsher Feb 05, 2013

ixgbe: Fix SR-IOV MTU warning



This change corrects the fact that we were using 1522 to test for the
max frame size in ixgbe_change_mtu and 1518 in ixgbe_set_vf_lpe.  The
difference was the addition of VLAN_HLEN which we only need to add in the case
of computing a buffer size, but not a filter size.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Sibai Li <Sibai.li@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 7e63bf49

drivers/net/ethernet/intel/ixgbe/ixgbe.h

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -92,8 +92,6 @@
	*/		*/
	#define IXGBE_RX_HDR_SIZE IXGBE_RXBUFFER_256		#define IXGBE_RX_HDR_SIZE IXGBE_RXBUFFER_256

	#define MAXIMUM_ETHERNET_VLAN_SIZE (ETH_FRAME_LEN + ETH_FCS_LEN + VLAN_HLEN)

	/* How many Rx Buffers do we bundle into one write to the hardware ? */		/* How many Rx Buffers do we bundle into one write to the hardware ? */
	#define IXGBE_RX_BUFFER_WRITE 16 /* Must be power of 2 */		#define IXGBE_RX_BUFFER_WRITE 16 /* Must be power of 2 */

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -4869,7 +4869,7 @@ static int ixgbe_change_mtu(struct net_device *netdev, int new_mtu)
	*/		*/
	if ((adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) &&		if ((adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) &&
	(adapter->hw.mac.type == ixgbe_mac_82599EB) &&		(adapter->hw.mac.type == ixgbe_mac_82599EB) &&
	(max_frame > MAXIMUM_ETHERNET_VLAN_SIZE))		(max_frame > (ETH_FRAME_LEN + ETH_FCS_LEN)))
	e_warn(probe, "Setting MTU > 1500 will disable legacy VFs\n");		e_warn(probe, "Setting MTU > 1500 will disable legacy VFs\n");

	e_info(probe, "changing MTU from %d to %d\n", netdev->mtu, new_mtu);		e_info(probe, "changing MTU from %d to %d\n", netdev->mtu, new_mtu);