Commit 7e63bf49 authored Jan 08, 2013 by Alexander Duyck Committed by Jeff Kirsher Feb 05, 2013

ixgbe: Replace rmb in Tx cleanup with read_barrier_depends

The rmb in the Tx cleanup path is a much stronger barrier than we really need.
All that is really needed is a read_barrier_depends since the location of the
EOP descriptor is dependent on the eop_desc value.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 434c5e39

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -838,7 +838,7 @@ static bool ixgbe_clean_tx_irq(struct ixgbe_q_vector *q_vector,
	break;		break;

	/* prevent any other reads prior to eop_desc */		/* prevent any other reads prior to eop_desc */
	rmb();		read_barrier_depends();

	/* if DD is not set pending work has not been completed */		/* if DD is not set pending work has not been completed */
	if (!(eop_desc->wb.status & cpu_to_le32(IXGBE_TXD_STAT_DD)))		if (!(eop_desc->wb.status & cpu_to_le32(IXGBE_TXD_STAT_DD)))