UPSTREAM: sched: Fix out-of-bound access in uclamp
Util-clamp places tasks in different buckets based on their clamp values for performance reasons. However, the size of buckets is currently computed using a rounding division, which can lead to an off-by-one error in some configurations. For instance, with 20 buckets, the bucket size will be 1024/20=51. A task with a clamp of 1024 will be mapped to bucket id 1024/51=20. Sadly, correct indexes are in range [0,19], hence leading to an out of bound memory access. Clamp the bucket id to fix the issue. Bug: 186415778 Fixes: 69842cba9ace ("sched/uclamp: Add CPU's clamp buckets refcounting") Suggested-by:Qais Yousef <qais.yousef@arm.com> Signed-off-by:
Quentin Perret <qperret@google.com> Signed-off-by:
Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by:
Vincent Guittot <vincent.guittot@linaro.org> Reviewed-by:
Dietmar Eggemann <dietmar.eggemann@arm.com> Link: https://lkml.kernel.org/r/20210430151412.160913-1-qperret@google.com (cherry picked from commit 6d2f8909a5fabb73fe2a63918117943986c39b6c) Signed-off-by:
Quentin Perret <qperret@google.com> Change-Id: I8097f5ed34abcff36c5ed395643d65727ea969eb
Loading
Please register or sign in to comment