x86, kaslr: fix module lock ordering problem
There was a potential lock ordering problem with the module kASLR patch
("x86, kaslr: randomize module base load address"). This patch removes
the usage of the module_mutex and creates a new mutex to protect the
module base address offset value.
Chain exists of:
  text_mutex --> kprobe_insn_slots.mutex --> module_mutex
[    0.515561]  Possible unsafe locking scenario:
[    0.515561]
[    0.515561]        CPU0                    CPU1
[    0.515561]        ----                    ----
[    0.515561]   lock(module_mutex);
[    0.515561]                                lock(kprobe_insn_slots.mutex);
[    0.515561]                                lock(module_mutex);
[    0.515561]   lock(text_mutex);
[    0.515561]
[    0.515561]  *** DEADLOCK ***
Reported-by: 
Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: 
Andy Honig <ahonig@google.com>
Signed-off-by: 
Kees Cook <keescook@chromium.org>
Reviewed-by: 
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: 
H. Peter Anvin <hpa@linux.intel.com>
Loading
Please register or sign in to comment