can: bcm: check for null sk before deferencing it via the call to sock_net
The assignment of net via call sock_net will dereference sk. This
is performed before a sanity null check on sk, so there could be
a potential null dereference on the sock_net call if sk is null.
Fix this by assigning net after the sk null check. Also replace
the sk == NULL with the more usual !sk idiom.
Detected by CoverityScan CID#1431862 ("Dereference before null check")
Fixes: 384317ef ("can: network namespace support for CAN_BCM protocol")
Signed-off-by:
Colin Ian King <colin.king@canonical.com>
Acked-by:
Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de>
Loading
Please register or sign in to comment