Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 366b4010 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Mauro Carvalho Chehab
Browse files

media: davinci: don't override the error code 



As warned by Coverity:
	CID 1415211 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
	Assigning value -22 to ret here, but that stored value is
	overwritten before it can be used.

On all cases where the there's a goto 'unlock_out' or 'streamof',
ret was filled with a non-sero value. It toesn't make sense to override
such error code with a videobuf_streamoff() error.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent fd901b6e

drivers/media/platform/davinci/vpfe_capture.c

+1 −1
Original line number Diff line number Diff line
@@ -1509,7 +1509,7 @@ static int vpfe_streamon(struct file *file, void *priv, 
unlock_out:

	mutex_unlock(&vpfe_dev->lock);

streamoff:

	ret = videobuf_streamoff(&vpfe_dev->buffer_queue);

	videobuf_streamoff(&vpfe_dev->buffer_queue);

	return ret;

}