Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd901b6e authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Mauro Carvalho Chehab
Browse files

media: em28xx: Don't use ops->resume if NULL 



Changeset  be7fd3c3 ("media: em28xx: Hauppauge DualHD
second tuner functionality") introduced a potential NULL pointer
dereference, as pointed by Coverity:

CID 1434731 (#1 of 1): Dereference after null check (FORWARD_NULL)16. var_deref_op: Dereferencing null pointer ops->resume.

var_compare_op: Comparing ops->resume to null implies that ops->resume might be null.
1174                if (ops->resume)
1175                        ops->resume(dev);
1176                if (dev->dev_next)
1177                        ops->resume(dev->dev_next);

Fixes: be7fd3c3 ("media: em28xx: Hauppauge DualHD second tuner functionality")

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent de6dddff

drivers/media/usb/em28xx/em28xx-core.c

+3 −2
Original line number Diff line number Diff line
@@ -1171,7 +1171,8 @@ int em28xx_resume_extension(struct em28xx *dev) 
	dev_info(&dev->intf->dev, "Resuming extensions\n");

	mutex_lock(&em28xx_devlist_mutex);

	list_for_each_entry(ops, &em28xx_extension_devlist, next) {

		if (ops->resume)

		if (!ops->resume)

			continue;

		ops->resume(dev);

		if (dev->dev_next)

			ops->resume(dev->dev_next);