Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6e1467d authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf symbols: Don't try to read the build-id twice 



In __dsos__read_build_ids if the dso already had its build-id read,
don't try again.

Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ce7f1545

tools/perf/util/symbol.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -1131,6 +1131,10 @@ bool __dsos__read_build_ids(struct list_head *head, bool with_hits) 
	list_for_each_entry(pos, head, node) {

	list_for_each_entry(pos, head, node) {

		if (with_hits && !pos->hit)

		if (with_hits && !pos->hit)

			continue;

			continue;

		if (pos->has_build_id) {

			have_build_id = true;

			continue;

		}

		if (filename__read_build_id(pos->long_name, pos->build_id,

		if (filename__read_build_id(pos->long_name, pos->build_id,

					    sizeof(pos->build_id)) > 0) {

					    sizeof(pos->build_id)) > 0) {

			have_build_id	  = true;

			have_build_id	  = true;