Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f56b0fbc authored by Al Viro's avatar Al Viro
Browse files

coda: clean failure exits in coda_fill_super() 



same as for cifs, move iput() to the right place, make it unconditional

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 064326c0

fs/coda/inode.c

+1 −4
Original line number Diff line number Diff line
@@ -208,7 +208,6 @@ static int coda_fill_super(struct super_block *sb, void *data, int silent) 
        if (IS_ERR(root)) {

		error = PTR_ERR(root);

		printk("Failure of coda_cnode_make for root: error %d\n", error);

		root = NULL;

		goto error;

	}
@@ -216,15 +215,13 @@ static int coda_fill_super(struct super_block *sb, void *data, int silent) 
	       root->i_ino, root->i_sb->s_id);

	sb->s_root = d_alloc_root(root);

	if (!sb->s_root) {

		iput(root);

		error = -EINVAL;

		goto error;

	}

	return 0;



error:

	if (root)

		iput(root);



	mutex_lock(&vc->vc_mutex);

	bdi_destroy(&vc->bdi);

	vc->vc_sb = NULL;