Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 064326c0 authored by Al Viro's avatar Al Viro
Browse files

clean up the failure exits in cifs_read_super()



no need to make that iput() conditional, just take it to the right place...

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 9bcb4b73
Loading
Loading
Loading
Loading
+1 −4
Original line number Diff line number Diff line
@@ -119,7 +119,6 @@ cifs_read_super(struct super_block *sb)

	if (IS_ERR(inode)) {
		rc = PTR_ERR(inode);
		inode = NULL;
		goto out_no_root;
	}

@@ -127,6 +126,7 @@ cifs_read_super(struct super_block *sb)

	if (!sb->s_root) {
		rc = -ENOMEM;
		iput(inode);
		goto out_no_root;
	}

@@ -147,9 +147,6 @@ cifs_read_super(struct super_block *sb)

out_no_root:
	cERROR(1, "cifs_read_super: get root inode failed");
	if (inode)
		iput(inode);

	return rc;
}