Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d122db7e authored by Stephen Boyd's avatar Stephen Boyd
Browse files

clk: basic-types: Remove useless allocation failure printks 



Printing an error on kmalloc() failures is unnecessary. Remove
the print and use *ptr in sizeof() for future-proof code.

Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent e0cdcda5

drivers/clk/clk-composite.c

+1 −3
Original line number Diff line number Diff line
@@ -200,10 +200,8 @@ struct clk *clk_register_composite(struct device *dev, const char *name, 
	struct clk_ops *clk_composite_ops;



	composite = kzalloc(sizeof(*composite), GFP_KERNEL);

	if (!composite) {

		pr_err("%s: could not allocate composite clk\n", __func__);

	if (!composite)

		return ERR_PTR(-ENOMEM);

	}



	init.name = name;

	init.flags = flags | CLK_IS_BASIC;

drivers/clk/clk-divider.c

+2 −4
Original line number Diff line number Diff line
@@ -430,11 +430,9 @@ static struct clk *_register_divider(struct device *dev, const char *name, 
	}



	/* allocate the divider */

	div = kzalloc(sizeof(struct clk_divider), GFP_KERNEL);

	if (!div) {

		pr_err("%s: could not allocate divider clk\n", __func__);

	div = kzalloc(sizeof(*div), GFP_KERNEL);

	if (!div)

		return ERR_PTR(-ENOMEM);

	}



	init.name = name;

	init.ops = &clk_divider_ops;

drivers/clk/clk-fixed-factor.c

+1 −3
Original line number Diff line number Diff line
@@ -74,10 +74,8 @@ struct clk *clk_register_fixed_factor(struct device *dev, const char *name, 
	struct clk *clk;



	fix = kmalloc(sizeof(*fix), GFP_KERNEL);

	if (!fix) {

		pr_err("%s: could not allocate fixed factor clk\n", __func__);

	if (!fix)

		return ERR_PTR(-ENOMEM);

	}



	/* struct clk_fixed_factor assignments */

	fix->mult = mult;

drivers/clk/clk-fixed-rate.c

+2 −4
Original line number Diff line number Diff line
@@ -65,11 +65,9 @@ struct clk *clk_register_fixed_rate_with_accuracy(struct device *dev, 
	struct clk_init_data init;



	/* allocate fixed-rate clock */

	fixed = kzalloc(sizeof(struct clk_fixed_rate), GFP_KERNEL);

	if (!fixed) {

		pr_err("%s: could not allocate fixed clk\n", __func__);

	fixed = kzalloc(sizeof(*fixed), GFP_KERNEL);

	if (!fixed)

		return ERR_PTR(-ENOMEM);

	}



	init.name = name;

	init.ops = &clk_fixed_rate_ops;

drivers/clk/clk-fractional-divider.c

+1 −3
Original line number Diff line number Diff line
@@ -109,10 +109,8 @@ struct clk *clk_register_fractional_divider(struct device *dev, 
	struct clk *clk;



	fd = kzalloc(sizeof(*fd), GFP_KERNEL);

	if (!fd) {

		dev_err(dev, "could not allocate fractional divider clk\n");

	if (!fd)

		return ERR_PTR(-ENOMEM);

	}



	init.name = name;

	init.ops = &clk_fractional_divider_ops;