Commit e0cdcda5 authored May 13, 2015 by Krzysztof Kozlowski Committed by Stephen Boyd May 14, 2015

clk: ti: dra7-atl-clock: Fix possible ERR_PTR dereference



of_clk_get_from_provider() returns ERR_PTR on failure. The
dra7-atl-clock driver was not checking its return value and
immediately used it in __clk_get_hw().  __clk_get_hw()
dereferences supplied clock, if it is not NULL, so in that case
it would dereference an ERR_PTR.

Fixes: 9ac33b0c ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

parent beb7a2a9

drivers/clk/ti/clk-dra7-atl.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -252,6 +252,11 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
		}

		clk = of_clk_get_from_provider(&clkspec);
		if (IS_ERR(clk)) {
		pr_err("%s: failed to get atl clock %d from provider\n",
		__func__, i);
		return PTR_ERR(clk);
		}

		cdesc = to_atl_desc(__clk_get_hw(clk));
		cdesc->cinfo = cinfo;