Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1818f17 authored by Benoit Taine's avatar Benoit Taine Committed by Christoph Hellwig
Browse files

qla2xxx: Use kmemdup instead of kmalloc + memcpy 



This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: default avatarBenoit Taine <benoit.taine@lip6.fr>
Acked-by: default avatarSaurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 3d30b439

drivers/scsi/qla2xxx/qla_mbx.c

+1 −2
Original line number Diff line number Diff line
@@ -1319,7 +1319,7 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len) 


		left = 0;



		list = kzalloc(dma_size, GFP_KERNEL);

		list = kmemdup(pmap, dma_size, GFP_KERNEL);

		if (!list) {

			ql_log(ql_log_warn, vha, 0x1140,

			    "%s(%ld): failed to allocate node names list "
@@ -1328,7 +1328,6 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len) 
			goto out_free;

		}



		memcpy(list, pmap, dma_size);

restart:

		dma_free_coherent(&ha->pdev->dev, dma_size, pmap, pmap_dma);

	}