Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d30b439 authored by Benoit Taine's avatar Benoit Taine Committed by Christoph Hellwig
Browse files

qla4xxx: Use kmemdup instead of kmalloc + memcpy 



This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: default avatarBenoit Taine <benoit.taine@lip6.fr>
Acked-by: default avatarVikas Chaudhary <vikas.chaudhary@qlogic.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent f92f82d6

drivers/scsi/qla4xxx/ql4_os.c

+3 −4
Original line number Diff line number Diff line
@@ -3565,14 +3565,13 @@ static int qla4xxx_copy_from_fwddb_param(struct iscsi_bus_flash_session *sess, 
	if (test_bit(OPT_IPV6_DEVICE, &options)) {

		conn->ipv6_traffic_class = fw_ddb_entry->ipv4_tos;



		conn->link_local_ipv6_addr = kzalloc(IPv6_ADDR_LEN, GFP_KERNEL);

		conn->link_local_ipv6_addr = kmemdup(

					fw_ddb_entry->link_local_ipv6_addr,

					IPv6_ADDR_LEN, GFP_KERNEL);

		if (!conn->link_local_ipv6_addr) {

			rc = -ENOMEM;

			goto exit_copy;

		}



		memcpy(conn->link_local_ipv6_addr,

		       fw_ddb_entry->link_local_ipv6_addr, IPv6_ADDR_LEN);

	} else {

		conn->ipv4_tos = fw_ddb_entry->ipv4_tos;

	}