Commit b168dfc5 authored Apr 17, 2009 by Jesse Brandeburg Committed by David S. Miller Apr 20, 2009

igb: fix link down inital state



As reported by Andrew Lutomirski <amluto@gmail.com>

All the intel wired ethernet drivers were calling netif_carrier_off
and netif_stop_queue (or variants) before calling register_netdevice

This is incorrect behavior as was pointed out by davem, and causes
ifconfig and friends to report a strange state before first link
after the driver was loaded, since without a netif_carrier_off, the stack
assumes carrier_on, but before register_netdev, netlink messages are not
sent out telling link state.

This apparently confused *some* versions of networkmanager.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reported-by: Andrew Lutomirski <amluto@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3a6d1bc4

drivers/net/igb/igb_main.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -1442,15 +1442,14 @@ static int __devinit igb_probe(struct pci_dev *pdev,
		* driver. */
		igb_get_hw_control(adapter);

		/* tell the stack to leave us alone until igb_open() is called */
		netif_carrier_off(netdev);
		netif_tx_stop_all_queues(netdev);

		strcpy(netdev->name, "eth%d");
		err = register_netdev(netdev);
		if (err)
		goto err_register;

		/* carrier off reporting is important to ethtool even BEFORE open */
		netif_carrier_off(netdev);

		#ifdef CONFIG_IGB_DCA
		if (dca_add_requester(&pdev->dev) == 0) {
		adapter->flags \|= IGB_FLAG_DCA_ENABLED;
		@@ -1699,6 +1698,8 @@ static int igb_open(struct net_device *netdev)
		if (test_bit(__IGB_TESTING, &adapter->state))
		return -EBUSY;

		netif_carrier_off(netdev);

		/* allocate transmit descriptors */
		err = igb_setup_all_tx_resources(adapter);
		if (err)