Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1437dcb authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: rcar: enhance comment to avoid regressions 



Give a clear testcase for people wishing to change this code. It is also
a reminder for me if people ask about it.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 27aaa8ad

drivers/i2c/busses/i2c-rcar.c

+2 −0
Original line number Diff line number Diff line
@@ -542,6 +542,8 @@ static void rcar_i2c_irq_recv(struct rcar_i2c_priv *priv, u32 msr) 
	 * If next received data is the _LAST_, go to STOP phase. Might be

	 * overwritten by REP START when setting up a new msg. Not elegant

	 * but the only stable sequence for REP START I have found so far.

	 * If you want to change this code, make sure sending one transfer with

	 * four messages (WR-RD-WR-RD) works!

	 */

	if (priv->pos + 1 >= msg->len)

		rcar_i2c_write(priv, ICMCR, RCAR_BUS_PHASE_STOP);