Commit 9a69b7ae authored Jan 25, 2018 by Jia-Ju Bai Committed by Herbert Xu Feb 15, 2018

crypto: user - Replace GFP_ATOMIC with GFP_KERNEL in crypto_report

After checking all possible call chains to crypto_report here,
my tool finds that crypto_report is never called in atomic context.
And crypto_report calls crypto_alg_match which calls down_read,
thus it proves again that crypto_report can call functions which may sleep.
Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 1ca28098

crypto/crypto_user.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -271,7 +271,7 @@ static int crypto_report(struct sk_buff in_skb, struct nlmsghdr in_nlh,
		return -ENOENT;

		err = -ENOMEM;
		skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC);
		skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
		if (!skb)
		goto drop_alg;