Commit 1ca28098 authored Jan 25, 2018 by Jia-Ju Bai Committed by Herbert Xu Feb 15, 2018

crypto: rsa-pkcs1pad - Replace GFP_ATOMIC with GFP_KERNEL in pkcs1pad_encrypt_sign_complete

After checking all possible call chains to kzalloc here,
my tool finds that this kzalloc is never called in atomic context.
Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent c7f582f5

crypto/rsa-pkcs1pad.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -192,7 +192,7 @@ static int pkcs1pad_encrypt_sign_complete(struct akcipher_request *req, int err)
		if (likely(!pad_len))
		goto out;

		out_buf = kzalloc(ctx->key_size, GFP_ATOMIC);
		out_buf = kzalloc(ctx->key_size, GFP_KERNEL);
		err = -ENOMEM;
		if (!out_buf)
		goto out;