Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 942e7e5f authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net/mlx4_core: fix incorrect size allocation for dev->caps.spec_qps 



The current allocation for dev->caps.spec_qps is for the size of the
pointer and not the size of the actual  mlx4_spec_qps structure.  Fix
this by using the correct size.   Also splint allocation over a few
lines to make it cppcheck clean on overly wide lines.

Detected by CoverityScan, CID#1455222 ("Wrong sizeof argument")

Fixes: c73c8b1e ("net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 542deb88

drivers/net/ethernet/mellanox/mlx4/qp.c

+3 −2
Original line number Diff line number Diff line
@@ -844,8 +844,9 @@ int mlx4_init_qp_table(struct mlx4_dev *dev) 


		/* In mfunc, calculate proxy and tunnel qp offsets for the PF here,

		 * since the PF does not call mlx4_slave_caps */

		dev->caps.spec_qps = kcalloc(dev->caps.num_ports, sizeof(dev->caps.spec_qps), GFP_KERNEL);



		dev->caps.spec_qps = kcalloc(dev->caps.num_ports,

					     sizeof(*dev->caps.spec_qps),

					     GFP_KERNEL);

		if (!dev->caps.spec_qps) {

			err = -ENOMEM;

			goto err_mem;