Commit 542deb88 authored Aug 31, 2017 by Colin Ian King Committed by David S. Miller Sep 03, 2017

net/mlx4_core: fix memory leaks on error exit path



The structures hca_param and func_cap are not being kfree'd on an error
exit path causing two memory leaks. Fix this by jumping to the existing
free memory error exit path.

Detected by CoverityScan, CID#1455219, CID#1455224 ("Resource Leak")

Fixes: c73c8b1e ("net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 32d9b70a

drivers/net/ethernet/mellanox/mlx4/main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -977,7 +977,8 @@ static int mlx4_slave_cap(struct mlx4_dev *dev)
		if (dev->caps.num_ports > MLX4_MAX_PORTS) {
		mlx4_err(dev, "HCA has %d ports, but we only support %d, aborting\n",
		dev->caps.num_ports, MLX4_MAX_PORTS);
		return -ENODEV;
		err = -ENODEV;
		goto free_mem;
		}

		mlx4_replace_zero_macs(dev);