Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d5d775a authored Apr 19, 2012 by Marcel Holtmann Committed by Gustavo Padovan May 09, 2012

Bluetooth: Split error handling for SCO listen sockets



Split the checks for sk->sk_state and sk->sk_type for SCO listen
sockets. This makes the code more readable.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo@padovan.org>

parent 6b3af733

net/bluetooth/sco.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -539,11 +539,16 @@ static int sco_sock_listen(struct socket *sock, int backlog)

		lock_sock(sk);

		if (sk->sk_state != BT_BOUND \|\| sock->type != SOCK_SEQPACKET) {
		if (sk->sk_state != BT_BOUND) {
		err = -EBADFD;
		goto done;
		}

		if (sk->sk_type != SOCK_SEQPACKET) {
		err = -EINVAL;
		goto done;
		}

		sk->sk_max_ack_backlog = backlog;
		sk->sk_ack_backlog = 0;
		sk->sk_state = BT_LISTEN;