Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b3af733 authored by Marcel Holtmann's avatar Marcel Holtmann Committed by Gustavo Padovan
Browse files

Bluetooth: Split error handling for L2CAP listen sockets 



Split the checks for sk->sk_state and sk->sk_type for L2CAP listen
sockets. This makes the code more readable.

Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarGustavo Padovan <gustavo@padovan.org>
parent 35d4adcc

net/bluetooth/l2cap_sock.c

+6 −2
Original line number Diff line number Diff line
@@ -148,12 +148,16 @@ static int l2cap_sock_listen(struct socket *sock, int backlog) 


	lock_sock(sk);



	if ((sock->type != SOCK_SEQPACKET && sock->type != SOCK_STREAM)

			|| sk->sk_state != BT_BOUND) {

	if (sk->sk_state != BT_BOUND) {

		err = -EBADFD;

		goto done;

	}



	if (sk->sk_type != SOCK_SEQPACKET && sk->sk_type != SOCK_STREAM) {

		err = -EINVAL;

		goto done;

	}



	switch (chan->mode) {

	case L2CAP_MODE_BASIC:

		break;