Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7aec53ac authored by Russell King's avatar Russell King Committed by Russell King
Browse files

[ARM] omap: ensure that failing power domain lookups produce errors 



Use pr_err() for errors rather than pr_debug().  pr_debug() are
compiled away unless -DDEBUG is used.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 7eb1afc9

arch/arm/mach-omap2/clockdomain.c

+5 −8
Original line number Diff line number Diff line
@@ -74,14 +74,11 @@ static void _autodep_lookup(struct clkdm_pwrdm_autodep *autodep) 


	pwrdm = pwrdm_lookup(autodep->pwrdm.name);

	if (!pwrdm) {

		pr_debug("clockdomain: _autodep_lookup: powerdomain %s "

			 "does not exist\n", autodep->pwrdm.name);

		WARN_ON(1);

		pr_err("clockdomain: autodeps: powerdomain %s does not exist\n",

			 autodep->pwrdm.name);

		pwrdm = ERR_PTR(-ENOENT);

	}

	autodep->pwrdm.ptr = pwrdm;



	return;

}



/*
@@ -211,8 +208,8 @@ int clkdm_register(struct clockdomain *clkdm) 


	pwrdm = pwrdm_lookup(clkdm->pwrdm.name);

	if (!pwrdm) {

		pr_debug("clockdomain: clkdm_register %s: powerdomain %s "

			 "does not exist\n", clkdm->name, clkdm->pwrdm.name);

		pr_err("clockdomain: %s: powerdomain %s does not exist\n",

			clkdm->name, clkdm->pwrdm.name);

		return -EINVAL;

	}

	clkdm->pwrdm.ptr = pwrdm;
@@ -222,7 +219,7 @@ int clkdm_register(struct clockdomain *clkdm) 
	if (_clkdm_lookup(clkdm->name)) {

		ret = -EEXIST;

		goto cr_unlock;

	};

	}



	list_add(&clkdm->node, &clkdm_list);