Commit 737f644c authored May 23, 2013 by Lars-Peter Clausen Committed by Dmitry Torokhov May 23, 2013

Input: navpoint - pass correct pointer to free_irq()



free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 139097a0

drivers/input/mouse/navpoint.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -287,7 +287,7 @@ static int navpoint_probe(struct platform_device *pdev)
		return 0;

		err_free_irq:
		free_irq(ssp->irq, &pdev->dev);
		free_irq(ssp->irq, navpoint);
		err_free_mem:
		input_free_device(input);
		kfree(navpoint);