Commit 139097a0 authored May 23, 2013 by Lars-Peter Clausen Committed by Dmitry Torokhov May 23, 2013

Input: pmic8xxx-pwrkey - pass correct pointer to free_irq()



free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 25c9b7bd

drivers/input/misc/pmic8xxx-pwrkey.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -175,7 +175,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
		return 0;

		free_press_irq:
		free_irq(key_press_irq, NULL);
		free_irq(key_press_irq, pwrkey);
		unreg_input_dev:
		input_unregister_device(pwr);
		pwr = NULL;