Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50ac697b authored by Shubhrajyoti Datta's avatar Shubhrajyoti Datta Committed by Mark Brown
Browse files

spi: cadence: Fix probe error handling 



The clock disabling is missed out in some
error cases at probe. Fix the same.

Signed-off-by: default avatarShubhrajyoti Datta <shubhraj@xilinx.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 24746675

drivers/spi/spi-cadence.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -527,7 +527,7 @@ static int cdns_spi_probe(struct platform_device *pdev) 
	if (irq <= 0) {

	if (irq <= 0) {

		ret = -ENXIO;

		ret = -ENXIO;

		dev_err(&pdev->dev, "irq number is invalid\n");

		dev_err(&pdev->dev, "irq number is invalid\n");

		goto remove_master;

		goto clk_dis_all;

	}

	}





	ret = devm_request_irq(&pdev->dev, irq, cdns_spi_irq,

	ret = devm_request_irq(&pdev->dev, irq, cdns_spi_irq,
@@ -535,7 +535,7 @@ static int cdns_spi_probe(struct platform_device *pdev) 
	if (ret != 0) {

	if (ret != 0) {

		ret = -ENXIO;

		ret = -ENXIO;

		dev_err(&pdev->dev, "request_irq failed\n");

		dev_err(&pdev->dev, "request_irq failed\n");

		goto remove_master;

		goto clk_dis_all;

	}

	}





	master->prepare_transfer_hardware = cdns_prepare_transfer_hardware;

	master->prepare_transfer_hardware = cdns_prepare_transfer_hardware;