Commit 48c6b5c9 authored Apr 26, 2018 by Gustavo A. R. Silva Committed by Kalle Valo Apr 30, 2018

rsi_91x: fix uninitialized variable



There is a potential execution path in which variable ret is returned
without being properly initialized previously.

Fix this by storing the value returned by function
rsi_usb_master_reg_write into _ret_.

Addresses-Coverity-ID: 1468407 ("Uninitialized scalar variable")
Fixes: 16d3bb7b ("rsi: disable fw watchdog timer during reset")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent e1fd7cee

drivers/net/wireless/rsi/rsi_91x_usb.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -687,9 +687,10 @@ static int rsi_reset_card(struct rsi_hw *adapter)
		*/
		msleep(100);

		if (rsi_usb_master_reg_write(adapter, SWBL_REGOUT,
		ret = rsi_usb_master_reg_write(adapter, SWBL_REGOUT,
		RSI_FW_WDT_DISABLE_REQ,
		RSI_COMMON_REG_SIZE) < 0) {
		RSI_COMMON_REG_SIZE);
		if (ret < 0) {
		rsi_dbg(ERR_ZONE, "Disabling firmware watchdog timer failed\n");
		goto fail;
		}