Commit e1fd7cee authored Apr 26, 2018 by Gustavo A. R. Silva Committed by Kalle Valo Apr 30, 2018

rsi_91x: fix structurally dead code



Function rsi_hal_key_config returns before reaching code at line
922 if (status), hence this code is structurally dead.

Fix this by storing the value returned by rsi_hal_load_key
into _status_ for its further evaluation and use.

Addresses-Coverity-ID: 1468409 ("Structurally dead code")
Fixes: 4fd6c476 ("rsi: roaming enhancements")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 60f36637

drivers/net/wireless/rsi/rsi_91x_mac80211.c

+8 −8

Original line number	Diff line number	Diff line
		@@ -911,7 +911,7 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
		}
		}

		return rsi_hal_load_key(adapter->priv,
		status = rsi_hal_load_key(adapter->priv,
		key->key,
		key->keylen,
		key_type,