Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 435ea762 authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

greybus: connection: Don't free resources freed by gb_connection_release() 



We are already doing put_device() here and so don't need to free
resources directly, except ida.

Fixes: afde17fe0b61 ("greybus/connection: fix jump label on device_add failure")
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 22322c47

drivers/staging/greybus/connection.c

+1 −3
Original line number Diff line number Diff line
@@ -270,7 +270,7 @@ gb_connection_create_range(struct greybus_host_device *hd, 
		pr_err("failed to add connection device for cport 0x%04hx\n",

			cport_id);



		goto err_free_kfifo;

		goto err_remove_ida;

	}



	spin_lock_irq(&gb_connections_lock);
@@ -296,8 +296,6 @@ gb_connection_create_range(struct greybus_host_device *hd, 


	return connection;



err_free_kfifo:

	kfifo_free(&connection->ts_kfifo);

err_destroy_wq:

	destroy_workqueue(connection->wq);

err_free_connection: