Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22322c47 authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

greybus: connection: Destroy wq on failure 



Need to destroy the wq created earlier, do it.

Fixes: d0f1778a6b67 ("greybus/connection: add a timestamp kfifo to track connection handoff")
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent d65e3a22

drivers/staging/greybus/connection.c

+3 −1
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ gb_connection_create_range(struct greybus_host_device *hd, 


	if (kfifo_alloc(&connection->ts_kfifo, GB_CONNECTION_TS_KFIFO_LEN,

			GFP_KERNEL))

		goto err_free_connection;

		goto err_destroy_wq;



	connection->dev.parent = parent;

	connection->dev.bus = &greybus_bus_type;
@@ -298,6 +298,8 @@ gb_connection_create_range(struct greybus_host_device *hd, 


err_free_kfifo:

	kfifo_free(&connection->ts_kfifo);

err_destroy_wq:

	destroy_workqueue(connection->wq);

err_free_connection:

	kfree(connection);

err_remove_ida: