Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ff692fa authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: ov9640: make const arrays res_x/y static const, reduces object code size 



Don't populate the arrays res_x and resy_y on the stack, instead make them
static const.  Makes the object code smaller by over 160 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  10509	   2800	     64	  13373	   343d	ov9640.o

After:
   text	   data	    bss	    dec	    hex	filename
  10184	   2960	     64	  13208	   3398	ov9640.o

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent e90ce8aa

drivers/media/i2c/soc_camera/ov9640.c

+2 −2
Original line number Diff line number Diff line
@@ -335,8 +335,8 @@ static void ov9640_res_roundup(u32 *width, u32 *height) 
{

	int i;

	enum { QQCIF, QQVGA, QCIF, QVGA, CIF, VGA, SXGA };

	int res_x[] = { 88, 160, 176, 320, 352, 640, 1280 };

	int res_y[] = { 72, 120, 144, 240, 288, 480, 960 };

	static const int res_x[] = { 88, 160, 176, 320, 352, 640, 1280 };

	static const int res_y[] = { 72, 120, 144, 240, 288, 480, 960 };



	for (i = 0; i < ARRAY_SIZE(res_x); i++) {

		if (res_x[i] >= *width && res_y[i] >= *height) {