Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e90ce8aa authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: cobalt: remove redundant zero check on retval 



The error handling paths all end up with retval being non-zero,
so the check for retval being zero is always false and hence
is redundant. Remove it.

Detected by CoverityScan CID#1309479 ("Logically dead code")

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 2be730b8

drivers/media/pci/cobalt/cobalt-driver.c

+0 −2
Original line number Diff line number Diff line
@@ -767,8 +767,6 @@ static int cobalt_probe(struct pci_dev *pci_dev, 
err_wq:

	destroy_workqueue(cobalt->irq_work_queues);

err:

	if (retval == 0)

		retval = -ENODEV;

	cobalt_err("error %d on initialization\n", retval);



	v4l2_device_unregister(&cobalt->v4l2_dev);