Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 302c5608 authored by Akinobu Mita's avatar Akinobu Mita Committed by Alexandre Belloni
Browse files

rtc: rx8025: round up to nearest minute for a minute accuracy alarm 



The alarm for rx8025 only has a minute accuracy, so round up to nearest
minute when setting alarm.  Without doing this, rtctest blocks one day
after setting alarm to 5 seconds later.

pcf8563 and hym8563 also have similar handling.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 9dbe3852

drivers/rtc/rtc-rx8025.c

+11 −1
Original line number Diff line number Diff line
@@ -344,7 +344,17 @@ static int rx8025_set_alarm(struct device *dev, struct rtc_wkalrm *t) 
	if (client->irq <= 0)

		return -EINVAL;



	/* Hardware alarm precision is 1 minute! */

	/*

	 * Hardware alarm precision is 1 minute!

	 * round up to nearest minute

	 */

	if (t->time.tm_sec) {

		time64_t alarm_time = rtc_tm_to_time64(&t->time);



		alarm_time += 60 - t->time.tm_sec;

		rtc_time64_to_tm(alarm_time, &t->time);

	}



	ald[0] = bin2bcd(t->time.tm_min);

	if (rx8025->ctrl1 & RX8025_BIT_CTRL1_1224)

		ald[1] = bin2bcd(t->time.tm_hour);