Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9dbe3852 authored by Akinobu Mita's avatar Akinobu Mita Committed by Alexandre Belloni
Browse files

rtc: rx8025: protect ctrl1 register update by rtc->ops_lock 



The ctrl1 register is accessed by alarm operations.  But it is updated
in threaded interrupt handler without acquiring rtc->ops_lock.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 0a966c07

drivers/rtc/rtc-rx8025.c

+4 −0
Original line number Diff line number Diff line
@@ -146,8 +146,10 @@ static irqreturn_t rx8025_handle_irq(int irq, void *dev_id) 
{

	struct i2c_client *client = dev_id;

	struct rx8025_data *rx8025 = i2c_get_clientdata(client);

	struct mutex *lock = &rx8025->rtc->ops_lock;

	int status;



	mutex_lock(lock);

	status = rx8025_read_reg(client, RX8025_REG_CTRL2);

	if (status < 0)

		goto out;
@@ -172,6 +174,8 @@ static irqreturn_t rx8025_handle_irq(int irq, void *dev_id) 
	}



out:

	mutex_unlock(lock);



	return IRQ_HANDLED;

}