Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20c17675 authored by Russell King's avatar Russell King Committed by Dave Airlie
Browse files

drm/i2c: tda998x: fix npix/nline programming 



The npix/nline registers are supposed to be programmed with the total
number of pixels/lines, not the displayed pixels/lines, and not minus
one either.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Tested-by: default avatarDarren Etheridge <detheridge@ti.com>
Tested-by: default avatarSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Tested-by: default avatarRussell King <rmk_kernel@arm.linux.org.uk>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent bcb2481d

drivers/gpu/drm/i2c/tda998x_drv.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -587,8 +587,8 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, 
		reg_set(encoder, REG_VIP_CNTRL_3, VIP_CNTRL_3_H_TGL);

		reg_set(encoder, REG_VIP_CNTRL_3, VIP_CNTRL_3_H_TGL);





	reg_write(encoder, REG_VIDFORMAT, 0x00);

	reg_write(encoder, REG_VIDFORMAT, 0x00);

	reg_write16(encoder, REG_NPIX_MSB, mode->hdisplay - 1);

	reg_write16(encoder, REG_NPIX_MSB, mode->htotal);

	reg_write16(encoder, REG_NLINE_MSB, mode->vdisplay - 1);

	reg_write16(encoder, REG_NLINE_MSB, mode->vtotal);

	reg_write16(encoder, REG_VS_LINE_STRT_1_MSB, line_start);

	reg_write16(encoder, REG_VS_LINE_STRT_1_MSB, line_start);

	reg_write16(encoder, REG_VS_LINE_END_1_MSB, line_end);

	reg_write16(encoder, REG_VS_LINE_END_1_MSB, line_end);

	reg_write16(encoder, REG_VS_PIX_STRT_1_MSB, hs_start);

	reg_write16(encoder, REG_VS_PIX_STRT_1_MSB, hs_start);