Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18114746 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by David S. Miller
Browse files

[SUNRPC]: Remove unnecessary check in net/sunrpc/svcsock.c 



coverity spotted this one as possible dereference in the dprintk(),
but since there is only one caller of svc_create_socket(), which always
passes a valid sin, we dont need this check.

Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 96d2ca4e

net/sunrpc/svcsock.c

+6 −8
Original line number Diff line number Diff line
@@ -1393,14 +1393,12 @@ svc_create_socket(struct svc_serv *serv, int protocol, struct sockaddr_in *sin) 
	if ((error = sock_create_kern(PF_INET, type, protocol, &sock)) < 0)

		return error;



	if (sin != NULL) {

	if (type == SOCK_STREAM)

		sock->sk->sk_reuse = 1; /* allow address reuse */

	error = kernel_bind(sock, (struct sockaddr *) sin,

					sizeof(*sin));

	if (error < 0)

		goto bummer;

	}



	if (protocol == IPPROTO_TCP) {

		if ((error = kernel_listen(sock, 64)) < 0)