Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96d2ca4e authored by Al Viro's avatar Al Viro Committed by David S. Miller
Browse files

[IPVS] bug: endianness breakage in ip_vs_ftp 



(p[3]<<24) | (p[2]<<16) | (p[1]<<8) | p[0] is not a valid
way to spell get_unaligned((__be32 *)p

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 014d730d

net/ipv4/ipvs/ip_vs_ftp.c

+3 −2
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
#include <linux/ip.h>

#include <net/protocol.h>

#include <net/tcp.h>

#include <asm/unaligned.h>



#include <net/ip_vs.h>
@@ -114,8 +115,8 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, 
	if (i != 5)

		return -1;



	*addr = (p[3]<<24) | (p[2]<<16) | (p[1]<<8) | p[0];

	*port = (p[5]<<8) | p[4];

	*addr = get_unaligned((__be32 *)p);

	*port = get_unaligned((__be16 *)(p + 4));

	return 1;

}