Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14d7045c authored by Colin Ian King's avatar Colin Ian King Committed by Tejun Heo
Browse files

ata: sata_mv: remove a redundant assignment to pointer ehi 



The pointer ehi is being assigned to a value that is never read
and is redundant.  Clean up the code and move the ehi declaration
and initialization to the code block where it is used. Cleans up
clang warning: Value stored to 'ehi' is never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent b1314e3f

drivers/ata/sata_mv.c

+1 −3
Original line number Diff line number Diff line
@@ -2478,20 +2478,18 @@ static unsigned int mv_get_err_pmp_map(struct ata_port *ap) 


static void mv_pmp_eh_prep(struct ata_port *ap, unsigned int pmp_map)

{

	struct ata_eh_info *ehi;

	unsigned int pmp;



	/*

	 * Initialize EH info for PMPs which saw device errors

	 */

	ehi = &ap->link.eh_info;

	for (pmp = 0; pmp_map != 0; pmp++) {

		unsigned int this_pmp = (1 << pmp);

		if (pmp_map & this_pmp) {

			struct ata_link *link = &ap->pmp_link[pmp];

			struct ata_eh_info *ehi = &link->eh_info;



			pmp_map &= ~this_pmp;

			ehi = &link->eh_info;

			ata_ehi_clear_desc(ehi);

			ata_ehi_push_desc(ehi, "dev err");

			ehi->err_mask |= AC_ERR_DEV;