Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 14a07f1d authored by Markus Elfring's avatar Markus Elfring Committed by Mark Brown
Browse files

ASoC: da7218: Delete two error messages for a failed memory allocation in da7218_of_to_pdata() 



Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarAdam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bc6476d6

sound/soc/codecs/da7218.c

+1 −5
Original line number Diff line number Diff line
@@ -2455,10 +2455,8 @@ static struct da7218_pdata *da7218_of_to_pdata(struct snd_soc_codec *codec) 
	u32 of_val32;



	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);

	if (!pdata) {

		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");

	if (!pdata)

		return NULL;

	}



	if (of_property_read_u32(np, "dlg,micbias1-lvl-millivolt", &of_val32) >= 0)

		pdata->micbias1_lvl = da7218_of_micbias_lvl(codec, of_val32);
@@ -2527,8 +2525,6 @@ static struct da7218_pdata *da7218_of_to_pdata(struct snd_soc_codec *codec) 
		hpldet_pdata = devm_kzalloc(codec->dev, sizeof(*hpldet_pdata),

					    GFP_KERNEL);

		if (!hpldet_pdata) {

			dev_warn(codec->dev,

				 "Failed to allocate memory for hpldet pdata\n");

			of_node_put(hpldet_np);

			return pdata;

		}