Unverified Commit bc6476d6 authored Nov 13, 2017 by Johan Hovold Committed by Mark Brown Nov 16, 2017

ASoC: da7218: fix fix child-node lookup



Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.

To make things worse, the parent codec node was also prematurely freed.

Fixes: 4d50934a ("ASoC: da7218: Add da7218 codec driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable <stable@vger.kernel.org>

parent df6a3e24

sound/soc/codecs/da7218.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2520,7 +2520,7 @@ static struct da7218_pdata da7218_of_to_pdata(struct snd_soc_codec codec)
		}

		if (da7218->dev_id == DA7218_DEV_ID) {
		hpldet_np = of_find_node_by_name(np, "da7218_hpldet");
		hpldet_np = of_get_child_by_name(np, "da7218_hpldet");
		if (!hpldet_np)
		return pdata;